test_runner: add classname hierarchy for JUnit reporter - #60220
Merged
nodejs-github-bot merged 1 commit intoAug 20, 2026
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
atlowChemi
approved these changes
Oct 12, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60220 +/- ##
========================================
Coverage 90.13% 90.14%
========================================
Files 741 743 +2
Lines 242246 242429 +183
Branches 45628 45664 +36
========================================
+ Hits 218350 218538 +188
+ Misses 15397 15392 -5
Partials 8499 8499
🚀 New features to boost your workflow:
|
mag123c
force-pushed
the
feature/junit-classname-hierarchy
branch
from
October 13, 2025 00:26
f738875 to
5e2a5d3
Compare
|
Hello @MoLow @pmarchini Could you take a look? Thank you. |
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
pmarchini
approved these changes
Jan 25, 2026
mag123c
force-pushed
the
feature/junit-classname-hierarchy
branch
from
January 26, 2026 00:48
5e2a5d3 to
175d312
Compare
|
Hello @MoLow Could you take a look? Thank you. |
MoLow
approved these changes
Mar 25, 2026
mag123c
force-pushed
the
feature/junit-classname-hierarchy
branch
from
April 4, 2026 03:59
175d312 to
e245584
Compare
MoLow
added
request-ci
MoLow
approved these changes
Apr 5, 2026
Member
|
@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time |
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/71009/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583 |
MoLow
added
request-ci
github-actions
Bot
removed
the
request-ci
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/71009/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464 |
github-actions
Bot
added
the
request-ci-failed
avivkeller
approved these changes
Jul 24, 2026
Member
|
@mag123c Please rebase |
mag123c
force-pushed
the
feature/junit-classname-hierarchy
branch
from
July 24, 2026 06:33
e245584 to
ddab7fe
Compare
Contributor
Author
|
Rebased onto main, thanks @avivkeller. |
Member
|
Can you amend your first commit, it must have a "Signed-off-by" trailer. |
Signed-off-by: mag123c <diehreo@gmail.com>
mag123c
force-pushed
the
feature/junit-classname-hierarchy
branch
from
July 26, 2026 05:56
ddab7fe to
b8c6928
Compare
Contributor
Author
|
Done, added the sign-off. Thanks @avivkeller! |
atlowChemi
approved these changes
Jul 26, 2026
atlowChemi
added
request-ci
github-actions
Bot
added
request-ci-failed
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
atlowChemi
removed
the
request-ci-failed
|
Hi everyone! As the author of the original issue (#59417), I just wanted to say thank you to @mag123c and all the reviewers for working on this. Since it has all the necessary approvals and the CI has run, is there anything else needed to get this merged? @avivkeller @atlowChemi |
Collaborator
Collaborator
atlowChemi
added
the
commit-queue
Collaborator
|
Landed in e2cb91d |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.
Previously, all tests had
classname="test".Now the classname reflects the suite hierarchy (e.g.,
classname="Math.Addition"for nested suites).